fix(logger): warn customers when the ALC log level is less verbose than log buffer #3834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
logger
ConnorKirk
commented
Apr 15, 2025
ConnorKirk
commented
Apr 15, 2025
ConnorKirk
force-pushed
the
fix/3821-emit-warning-when-alc-conflicts-with-log-buffer
branch
from
ec492b3 to
a399be4
Compare
pull-request-size
bot
added
size/M
ConnorKirk
commented
Apr 15, 2025
|
I know this PR is in draft stage, but please do not merge it before we have further discussion in issue #3821. I hope to write new comments by tomorrow. |
2 tasks
dreamorosi
changed the title
|
I had a chat with @leandrodamascena and we agreed that we should add another log warning when we flush the buffer that says something along the lines of (feel free to reword it): Longer-ish explanation as for why is in the linked issue. |
ConnorKirk
force-pushed
the
fix/3821-emit-warning-when-alc-conflicts-with-log-buffer
branch
from
f9d2fb5 to
c2a0e98
Compare
|
dreamorosi
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the Advanced Logging Control is less verbose than the Logger Log buffer, buffered logs will not be visible. This PR adds a warning that is emitted when this scenario is detected.
There's an existing warning message if the ALC Log Level is less verbose than the Logger Log Level.
Changes
Issue number: #3821
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.